UI: Add change host password #10337
UI: Add change host password #10337
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10337 +/- ##
============================================
+ Coverage 16.02% 16.15% +0.13%
- Complexity 13146 13264 +118
============================================
Files 5658 5667 +9
Lines 496312 497989 +1677
Branches 60109 60243 +134
============================================
+ Hits 79537 80468 +931
- Misses 407926 408512 +586
- Partials 8849 9009 +160
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
bernardodemarco
left a comment
bernardodemarco
left a comment
There was a problem hiding this comment.
lgtm, tested in a local environment.
Verified that the UI validates if the values inserted in the New password and Confirm password fields are equal. If they're not, then the message Please enter the same value again. is returned. Also verified that the API parameters are correctly specified when executing the updateHostPassword API.
|
@lucas-a-martins , is this applicanble to 4.20 as well? |
It is. Do you want me to rebase it and change the target branch? :) |
please lets not keep a good fix from people longer then needed. |
Co-authored-by: Bernardo De Marco Gonçalves <[email protected]>
lucas-a-martins
force-pushed
the
change-password-UI
branch
from
5ce9fa4 to
c5a8b0b
Compare
boring-cyborg
bot
added
component:api
component:backup
component:build
component:compute
component:kvm
component:management-server
component:networking
component:orchestration
component:primary-storage
component:storage
component:usage-server
component:virtual-router
Python
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
lucas-a-martins
removed
component:management-server
component:primary-storage
component:virtual-router
component:api
component:usage-server
component:networking
Python
|
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
* Add updateHostPassword API to UI * remove unnecessary check Co-authored-by: Bernardo De Marco Gonçalves <[email protected]> --------- Co-authored-by: Lucas Martins <[email protected]> Co-authored-by: Bernardo De Marco Gonçalves <[email protected]>
7 participants
Description
Currently is possible to change the host's password by using the
updateHostPasswordAPI; however, this option is not available in the UI.This PR adds the option to change the host's password via UI.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
In a local environment, I checked that the new option was available and tried to change the password using the new form. Looking the database I verified that the password changed.
I also forced some exceptions, like by using a wrong username as a parameter. Everything worked as expected.